Fullcalendar broken on F3.4.3 and current github

[zzzz54]

I?ve just repeat the update proccess and it shows the same error that i?ve mentioned before:

Uncaught TypeError: h.calendar.fullCalendar is not a function

http://prntscr.com/b06frb

thank you very much for your efforts

 

[cheesegrits]

I'll need to see the page. If it's on your Zoom site, the credentials you provided don't work.

-- hugh

 

[zzzz54]

credentials updated, please check again

index.php/direccion/anuncios/calendario-de-pruebas

 

[achartier]

Hugh, you can see my error on my algonquinclub production site using the specified credentials. Once logged in go to Club Administration->Committees->Security/Pool Signup

 

[zzzz54]

updated again, sorry for the mistake in the url. please let me know if you need administrator access or anything else.

 

[cheesegrits]

@achartier - can you try with Protostar, see if that's a template issue?

 

[cheesegrits]

@zzzz54 - if I append ?fabrikdebug=1 to your URL, which loads the uncompressed JS, it works. So I still think you haven't correctly uploaded the compressed fullcalendar-mins.js file.

-- hugh

 

[achartier]

@achartier - can you try with Protostar, see if that's a template issue?

OK, will have to do this on my test system, probably not until tomorrow. It was working just fine on my template until the recent update.

 

[zzzz54]

@zzzz54 - if I append ?fabrikdebug=1 to your URL, which loads the uncompressed JS, it works. So I still think you haven't correctly uploaded the compressed fullcalendar-mins.js file.

-- hugh

I?ve just downloaded again, and uploaded to the site (all git-hub package) but the same result: no calendar (only show the filters). nothing change.

// update: it starts to show the calendar. let me see if everything it?s ok and I?ll let you know. I?m so happy

// 2nd update: ok, it shows the calendar but only if I append ?fabrikdebug=1 to the url. I?ve tried editing (throught Cpanel) the fullcalendar-min.js by hand but it shows no changes .

also, when I switch between months all the data gone and it?s being fetched to the server again, taking at least one minute for each load.

Meanwhile I could say that it?s looks pretty nice!!! hugh, I will definitely invite you and rob and achartier one beer, just to say thanks for all your efforts. Please take your time, you are doing a great job.

fabrik the best!!!!!!!!!!

 

[achartier]

@achartier - can you try with Protostar, see if that's a template issue?

Tried it on my test system using Protostar with the same 2 errors.

 

[achartier]

The real problem seems to be the Mismatched anonymous defines that are getting pulled in by the require.js.

 

[zzzz54]

One thing that are getting my attention is that we (@achartier and me) are facing differents problems, but we are using the same git-package, plus to this, playing a bit with the calendar (appending ?fabrikdebug=1 to the url) I?ve noticed that the languaje file isn?t loaded. my site is in spanish and everything inside the calendar are being shown in english (I mean name of days, months, and today label).

I don?t want to merge all issues here, I?m just thinking that this information could be usefull to understand what is happening and why we are not getting the same error message.

 

[cheesegrits]

The real problem seems to be the Mismatched anonymous defines that are getting pulled in by the require.js.

Right, which I'm not getting on my site, and the only difference I can see is the YouJoomla YJSG framework stuff being loaded.

Does that still get loaded in Protostar (like by a system plugin)?

-- hugh

 

[achartier]

OK, I have narrowed it down to my onBeforeLoad form plugin. Will do some further investigation.

// oops. might have spoke too soon. Stand by while I continue to debug.

// update, OK, you are correct Hugh, it seems to be the template. Once I switched to Protostar (and cleared my cache!) the problem went away. I have opened at ticket at YouJoomla. They have been responsive in the past and worked with you directly to correct a pagination issue a year or so ago so am hopeful they will reach out if needed. Will update when I hear from them.

 

[zzzz54]

Do you have another advice for me Hugh?

 

[achartier]

I?ve noticed that the languaje file isn?t loaded. my site is in spanish and everything inside the calendar are being shown in english (I mean name of days, months, and today label).

I suspect I didn't account for other languages in the fullcalendar initialization. Fullcalendar has it's own language files outside of Joomla. I will have a look at this first chance I get.

 

[achartier]

I suspect I didn't account for other languages in the fullcalendar initialization. Fullcalendar has it's own language files outside of Joomla. I will have a look at this first chance I get.

zzzz54, my plan would be to set the fullcalendar language to whatever the users frontend language setting is. Is that going to work for you?

 

[zzzz54]

zzzz54, my plan would be to set the fullcalendar language to whatever the users frontend language setting is. Is that going to work for you?

yes please. thank you

 

[troester]

https://github.com/Fabrik/fabrik/commit/837e250e3d1669b36ae1796af8addcfd4d29d6af
was adding lanuage handling to full calendar.

It is working on my site (fr,en,de) with build343 branch but not with the current joomla3 branch.
Line 126 in fullcalendar.js of this commit has vanished from the current version,
it was removed here
https://github.com/Fabrik/fabrik/commit/ac6df030672675c6f215e76473cbf9325567a0ae

 

[achartier]

Right you are. It looks like Hugh rewrote a whole bunch of fullcalendar stuff to use jQuery and jLayoutsJs while I was away. I will try inserting this line back in and see what happens. If it works I will push the change.