fileupload element with mp4 video

[JBosir]

In form, modify, fileupload with mp4 video, is not displayed in firefox and explorer. This I think is for the plugin. Doing this change in "plugin \ fabrik_element \ fileupload \ models \ video.php" works (line 119):

$this->output="<object width=\"$w\" height=\"$h\" classid=\"clsid:02BF25D5-8C17-4B23-BC80-D3488ABDDC6B\" codebase=\"http://www.apple.com/qtactivex/qtplugin.cab\">
<param name=\"src\" value=\"$src\">
<param name=\"autoplay\" value=\"false\">
<param name=\"controller\" value=\"true\">
<embed src=\"$src\" width=\"$w\" height=\"$h\" autoplay=\"false\" controller=\"true\" pluginspage=\"http://www.apple.com/quicktime/download/\">
</embed>

by:

$this->output = "<object width=\"$w\" height=\"$h\" classid=\"clsid:02BF25D5-8C17-4B23-BC80-D3488ABDDC6B\" codebase=\"http://www.apple.com/qtactivex/qtplugin.cab\">
<param name=\"src\" value=\"$src\">
<param name=\"autoplay\" value=\"false\">
<param name=\"controls\" value=\"true\">
<video src=\"$src\" width=\"$w\" height=\"$h\" autoplay=\"false\" controls=\"true\" pluginspage=\"http://www.apple.com/quicktime/download/\">
</video>

Would be good if parameter $ w $ h (height and width) are taken from:
element, fileuplod, display, max width and max height

This is an idea if what you have into consideration.
Thank You.

 

[cheesegrits]

I'm testing a change at the moment, which uses the HTML5 video tag, with a fallback to the existing plugin. I should have it up on github some time today.

-- hugh

 

[cheesegrits]

OK, committed.

At the moment, we get $w and $h from the actual video file, by parsing it out with the getid3 library:

http://getid3.sourceforge.net/

I could potentially override that, but it woul dhave to be Yet Another Option on the file upload element, which I'm reluctatnt to add, as it already has a zillion options. What issue are you having with it using the dimensions of the actual video itself?

I just committed that HTML5 video tag update:

https://github.com/Fabrik/fabrik/commit/38c2bc8cb76a17eeee1837d4fb1753b6dd5ee757

-- hugh

 

[JBosir]

It works perfectly in all browsers. Thank You.