Databasejoin extra <br>

[davez]

My databasejoin elements are displaying an extra <br> after the select. I've tracked it down to :

plugins/fabrik_element/databasejoin/layouts/fabrik-element-databasejoin-form-final.php

if (!empty($d->control)) :
    echo $d->control . "<br />\n";
endif;

If I remove...

."<br />\n";

...from the script, it stops pumping out that extra <br> after the databasejoin select.

Any thoughts of why that's in there and why it's not being stripped out. I've tested this on generic templates and it's still there. Thank you!

 

[troester]

1. In general: It's a layout file, you can always override as you like
2. You are correct, it doesn't make much sense (but it's there since years). I assume it was inserted to get "Frontend select" below the element. But then it should be done there.

 

[franciscoapjunior]

I agree with troester, and also with davez. The code has been there for a long time, and because it's a layout file, I removed it, because for my projects, it doesn't make sense to have this code.

Keep an eye out for updates, which may bring the file back.
Whenever possible I create a copy of the standard file to suit my needs, so I will never lose changes made to standard fabirk files.