Replace with icons option only for first record...

[remico]

Hi all,

After the last Github from yesterday the "Replace Icon" feature for a element is not working. It will only replace the icon for the first record.

If you check this link http://greenfree.com/partner-overzicht you wil see the green "golf" icon for the first record it finds only, the others are displaying the "1" which is the actual table element value.

The problem is not "glued" to a record. If you do a search, first record found will show the icon.

Any ideas?

I'm now setting up a proper Git sync with TotoiseGit to better manage updates because I'm running into problems after a Github update too many times...

 

[rob]

I'm unable to replicate this one, try replacing the image name with the elements' value, so change it from 'golfbaan.png' to '1.png'

 

[remico]

Hi Rob,

Sorry for the late reply but I wanted to be a good one...

I did a bisect on the Git and it really resulted in resolving the problem, with this as result text. Hope that you can do something with it!

Bisect result (started on 3.0.8 release as last good):

6cb192602c5d83b66d19d978a8fe6f12fd42c0ba is the first bad commit​

commit 6cb192602c5d83b66d19d978a8fe6f12fd42c0ba​

Author: pollen8 <rob@pollen-8.co.uk>​

Date: Wed Aug 28 16:31:23 2013 +0200​

​

changed: element icon replacement in list view. Now priority is given to {elementname}_{value}.{ext}, then {value}.{ext} then {label}.{ext} - avoids issue where 2 elements in the same list use replace icons and have the same recorded values​

​

:040000 040000 18931062394b5a7dc23cb9d7991857eeddf81c91 2b2968720366064b9308341c9e533c1af08b1d9d Mcomponents​

​

 

[remico]

The modified files are:
components\com_fabrik\models\element.php
components\com_fabrik\models\elementlist.php

Modified on 28-08-2013 by pollen8

 

[rob]

have you tried assigning / creating images in the format indicated in that commit message?

 

[remico]

I'll give it a try and let you know!