JS error after update to Git 218

[jfquestiaux]

Joomla3/Fabrik 3.1 seems to be very JS sensitive...

I have a new error after this morning's update on list in the front-end:

Erreur : ReferenceError: winOpts is not defined
Fichier Source : http://www.betterliving.be/j3/media/com_fabrik/js/list-min.js
Ligne : 1

It is on this page : http://www.betterliving.be/j3/index.php?option=com_fabrik&view=list&listid=26&Itemid=120

The template is a customizaion of the Bootstrap template, but I have the same error with the original Bootstrap template as well.

 

[rob]

ack looks like I had got half way through modifying the ajax window code and had forgotten to come back to finish it off.

I *think* I have this working now. Its a bit of a change in the code so perhaps back up before updating and report back if you see any issues.

 

[jfquestiaux]

It is working but I have the following issue :

1. There is a JS error when you click on the "view" link:
   
   Erreur : ReferenceError: require is not defined
   Fichier Source : http://www.betterliving.be/j3/index...s&formid=39&rowid=1&tmpl=component&Itemid=120
   Ligne : 20
2. The pop-up opens but the icons (resizing and close) are missing. The actions works though but since the icons are not there it is confusing for the user. I made a screencast : http://screencast.com/t/S8lJ7HtUC1c
3. For an unknown reason the date-time element (standard Fabrik one created with the list, set to be hidden) is showing in the detail view (not in the form view).

 

[rob]

2 - Seems like the bootstrap template you are using doesn't have the same icon set as the one Joomla uses (icomoon @ http://kyleledbetter.com/jui/icons) - hence the missing icons, perhaps you can find a way to add those into your template?

1 & 3- It seems the js and css are not loading in the same way as on my test site, when the pop up window loads - I can't replicate this locally though so Im not sure what the difference is between our two sites. Can you try running with Joomla's debug on to load the non-minified versions of the js files to see if that effects things?

 

[jfquestiaux]

Hi Rob.

For the icons, it is OK now. Thanks for the pointer.

For the JS error though, it is still there, even with Fabrik JS debug on. Also I tested with the default Joomla template (protostar) and the default fabrik Bootstrap template and gets the same error, so normally it is not from my templates.

 

[jfquestiaux]

After update to GitHub 254, the error is still there.

 

[cheesegrits]

As we can't replicate this locally, we'll need access to your page.

-- hugh

 

[rob]

Ok the issue here was JFQ was using a custom details link, but one which points to a fabrik details page.

When we load a custom details link we load the window content in an iframe. So I had to add '&iframe=1' to the link to ensure that the fabrik details page knows its loaded in an iframe, and thus loads require.js

Then I altered our framework loader to ensure that bootstrap is loaded if an iframe is loaded.

-ROb

 

[jfquestiaux]

There is still an error, but it seems to be a Firefox (Mac and Windows) thing because on other browsers, it's fine.

The JS error reported by Firebug is:

Erreur : TypeError: this.getStyle(...) is null
Fichier Source : http://betterliving.be/j3/media/system/js/mootools-more.js
Ligne : 176

Th screenshots are made with Firefox and Chrome.

 

[cheesegrits]

I can't really tell you much from that error, as it only shows where the error is pitched in mootools, not where in the code is calling that getStyle() and causing the error.

Rob is away this week. If you want me to take a look in the meanwhile, catch me on our Skype session.

-- hugh

 

[rob]

seems to be a js error in jce. I've altered our code so that it will only load wysiwyg editors when the form and element are editable.
Of course I couldn't replicate the issue locally so I'm not 100% sure what I have done will fix your error, but logic says that it should!

 

[jfquestiaux]

Well, unfortunately there is no change after update to GitHub 277. But don't waste your time on this for the moment, the other issues are far more important.
I'll check with JCE if they can do something about this.

 

[jfquestiaux]

After Update to Git 328, the JS error is gone but there is still no wrapping at the end of the line on FF. Works fine on other browsers though (not tested on IE).

 

[jfquestiaux]

Well, after GitHub 336, JS error is back and still no wrapping occurs with FF.
I tested it with IE 8 though and it's fine there (no JS error and wrapping OK).