FixMe J5 Radio buttons to button group in repeated group

[kouwearie]

So, where do you think the error should be found? The element plugin or radiobutton plugin

 

[achartier]

The problem is in the form javascript. It is not an issue with the label, although that should probably be corrected as my browser is complaining about duplicate for statements. I know where the issue is happening and am working on trying to fix it.

 

[achartier]

I have most of this fixed. The only issue I have at the moment to solve is with radio's and Checkboxes if you have no default set when you add a group the value of the first element shows on the new group for these items. This is only partially correct though. The radio button shows as checked but the value itself is not set so if you save the form that button is not saved as checked.

Likely some css holdover. If you always have a default it works fine.

More work to do.

 

[achartier]

Can you unzip the attached into your root J! directory and test for me please. Other than the specific cases you pointed out I have not tested it any further so some thorough testing would be appreciated,

 

[achartier]

By the way, you will need to enable FabrikDebug or test with the Chrome debug window open so it gets the uncompressed javascript.

 

[kouwearie]

Testing it now.

 

[achartier]

Thanks. Want to get it into the production 4.0 release if all tests out. Please test very well.

 

[kouwearie]

By the way, you will need to enable FabrikDebug or test with the Chrome debug window open so it gets the uncompressed javascript.

One issue i ran into instead; The cloned radio button gets the value of its precessor, and if rendered as button group, cannot be clicked to change the value.

 

[achartier]

OK, will look at it. You ensured you were getting the uncompressed javascript files?

 

[kouwearie]

OK, will look at it. You ensured you were getting the uncompressed javascript files?

ofccourse, always use it when testing. I'll try it with a fresh install also

 

[achartier]

I am not seeing this behavior on my site. You can try it with the url I gave you before. Click on the menu item test

 

[kouwearie]

Owkay, your fix doing what it should. Running into issues with front end addition:

elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
startAddNewOption @ elementlist.js:146
e.extend.$owner @ mootools-core.js:787
(anoniem) @ elementlist.js:186
m @ mootools-core.js:2540
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
startAddNewOption @ elementlist.js:146
e.extend.$owner @ mootools-core.js:787
(anoniem) @ elementlist.js:186
m @ mootools-core.js:2540
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
startAddNewOption @ elementlist.js:146
e.extend.$owner @ mootools-core.js:787
(anoniem) @ elementlist.js:186
m @ mootools-core.js:2540
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
startAddNewOption @ elementlist.js:146
e.extend.$owner @ mootools-core.js:787
(anoniem) @ elementlist.js:186
m @ mootools-core.js:2540
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:186:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
startAddNewOption @ elementlist.js:146
e.extend.$owner @ mootools-core.js:787
(anoniem) @ elementlist.js:186
m @ mootools-core.js:2540
elementlist.js:146 Uncaught TypeError: this.subElements.getLast(...).findClassUp(...).clone is not a function
    at Object.startAddNewOption (elementlist.js:146:91)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.checkEnter (elementlist.js:128:22)
    at e.extend.$owner (mootools-core.js:787:27)
    at Object.<anonymous> (elementlist.js:182:26)
    at HTMLInputElement.m (mootools-core.js:2540:27)
startAddNewOption @ elementlist.js:146
e.extend.$owner @ mootools-core.js:787
checkEnter @ elementlist.js:128
e.extend.$owner @ mootools-core.js:787
(anoniem) @ elementlist.js:182
m @ mootools-core.js:2540

 

[achartier]

Does this happen on my site? If not what would I need to add to see the error?

 

[kouwearie]

Does this happen on my site? If not what would I need to add to see the error?

You need to enable front end additions. Then add options on the front end when rendered as button group.
Only add labels.

 

[achartier]

Same issue in Fabrik 3.

 

[kouwearie]

Same issue in Fabrik 3.

Nope, it works for me in Fabrik 3
*edit* You're probably right, im using the dropdown element, coded so it renders as bootstrap buttons

 

[kouwearie]

The official release has only worsened the behavior of the radiobutton plugin. When shown as buttons it is totally misbehaving, and it influences every repeated addition. No way to repeat, {i} doesnt increment.