-
New Commercial Services Section
We have now opened a commercial services section here on the forum for registered users. If you have a Fabrik project that you wish to have someone work on for you, post it under Help Wanted. If you are an application developer and wish to earn some money helping others, post your details under Fabrik Application Developers.
Both of these are unmoderated. It will be up to both parties to work out the details and come to an agreement.
-
Joomla 5.1
For running J!5.1 you must https://fabrikar.com/forums/index.php?wiki/update-from-github/ or include the new file manually https://fabrikar.com/forums/index.php?threads/joomla-5-1-and-fabrik-cannot-find-files-error.54473/post-285151 See also Announcements
Email list plugin translation missing
- Thread starter dimoss
- Start date
Nice!!)
Yes, this string is displayed if button text is empty.
The string is missing in email list plugin language files.
Strange that it is PLG_LIST_ENVELOPE_ENVELOPE, should be something like PLG_LIST_EMAIL_ENVELOPE
Found it:
it's composed in
...\components\com_fabrik\models\plugin-list.php
protected function buttonLabel()
{
$s = JString::strtoupper($this->buttonPrefix);
return JText::_('PLG_LIST_' . $s . '_' . $s);
}
The string is missing in email list plugin language files.
Strange that it is PLG_LIST_ENVELOPE_ENVELOPE, should be something like PLG_LIST_EMAIL_ENVELOPE
Found it:
it's composed in
...\components\com_fabrik\models\plugin-list.php
protected function buttonLabel()
{
$s = JString::strtoupper($this->buttonPrefix);
return JText::_('PLG_LIST_' . $s . '_' . $s);
}
Sophist
Guest
Yes. Though this method is overridden in email.php with:
The plugin-list buttonLabel uses this->buttonPrefix which in email.php is "envelope" - so we are clear about the cause.
The solution would appear to be to rename the label in the language files to PLG_LIST_ENVELOPE_ENVELOPE - or to avoid an error if PLG_LIST_EMAIL_EMAIL is used anywhere, to duplicate it.
I will create a fix later today.
S
Code:
protected function buttonLabel() {
return $this->getParams()->get('email_button_label', parent::buttonLabel());
}The plugin-list buttonLabel uses this->buttonPrefix which in email.php is "envelope" - so we are clear about the cause.
The solution would appear to be to rename the label in the language files to PLG_LIST_ENVELOPE_ENVELOPE - or to avoid an error if PLG_LIST_EMAIL_EMAIL is used anywhere, to duplicate it.
I will create a fix later today.
S
Sophist
Guest
See my previous comment - I have coded the fix and submitted it for review.
If you want to grab it and apply it yourself, please go to https://github.com/Sophist-UK/fabrik/commit/75917a4d7289056da8847674fd0b069765f70ec1 and grab the changes yourself.
If you want to grab it and apply it yourself, please go to https://github.com/Sophist-UK/fabrik/commit/75917a4d7289056da8847674fd0b069765f70ec1 and grab the changes yourself.
