Calc element failing after inline edit

[cchiacchierini]

I am having a similar issue to the one described in this thread: http://fabrikar.com/forums/index.ph...all-rows-using-inline-edit.36391/#post-183229, but I can not tell if this was ever resolved.

The problem: when I edit a record in list view using inline edit, the following calculation breaks for all rows in the list, returning a value of "false" instead of returning the appropriate image. The calc field works fine when editing is done via a form.

This is the calc element code:

if ('{opsinitiatives___status}' == 'Opportunity')
return '<img src="images/opsinitiativesstatus/opportunity.png" />';
 
else
if ('{opsinitiatives___status}' == 'Needs Analysis')
return '<img src="images/opsinitiativesstatus/needsanalysis.png" />';
 
else
if ('{opsinitiatives___status}' == 'Cost Benefit')
return '<img src="images/opsinitiativesstatus/costbenefit.png" />';

I have the inline edit set up like this:

And the calc element setup like this:

Enabling "Only Calc on Save" breaks the calculation altogether. "Ajax Calculation" works when using the form. The calculation also works when "Ajax Calculation" is set to no when using the form.

I am on J2.5.16 and Fabrik updated from Github on 11/21/13.

 

[rob]

I don't think the fix was back ported to fabrik3.0 - I've done that now -although I've not tested I've simply copied what Hugh fixed in that thread you referenced:

https://github.com/Fabrik/fabrik/commit/c6e00b5dbdfd5b7b5cf14757436ba7eba9029e57

 

[cchiacchierini]

Thanks so much, Rob. I copied replaced the existing calc.php with the one from your link, and the problem was resolved.

Some general questions:

• What is the shelf life for fabrik3.0?
• If it is short, should I be considering moving to J3 and Fabrik 3.1?
• If I do move, I have quite a few javascript elements and custom templates, how much work does it take to fix the javascript and the templates (generally speaking)?

 

[rob]

You're welcome

What is the shelf life for fabrik3.0?

We'll be supporting it until Joomla 2.5 is "end of life", so according to http://developer.joomla.org/development-status.html that's December 31, 2014

If it is short, should I be considering moving to J3 and Fabrik 3.1?

Not sure if you consider a year short, and it depends on the lifetime of your project. Also depends if you are considering doing a lot more work on your Fabrik install or if its pretty much stable. If your project is fairly large and working and you don't intent to change it much stick with Fabrik 3.0. If that's not the case then its shades of gray as to whether to change or not.

If I do move, I have quite a few javascript elements and custom templates, how much work does it take to fix the javascript and the templates (generally speaking)?

There's a list of changes in the wiki http://fabrikar.com/forums/index.php?wiki/upgrading-from-3-0-to-3-1/
Custom templates may well need to be re-written to make use of bootstrap, javascript stays pretty much the same but you need to edit and save any elements which you have added custom js code to.

 

[cheesegrits]

We will continue to support 3.0 for the lifetime of J! 2.5. However, we're pretty much at the point where it's "serious bug fixes only", that is, bugs which cause actual PHP errors, or involve security. We won't be adding new features, or doing much else by way of fixing things which don't actually throw errors, although for Pro users we will be a little more flexible. But we really do need to focus pretty much all our effort on J! 3.x and Fabrik 3.1 from here on.

In general, custom JS isn't that hard to port, but custom templates are an issue, as we've had to go with Bootstrap, and pretty much abandon our old templating.

So really, it's a case of when / if you would otherwise be migrating your site to J! 3.x.

-- hugh

 

[cheesegrits]

Crossed in the post. What he said.

-- hugh