Closing Curly in Form : Bug ?

[sunnyjey]

As per this thread,

http://fabrikar.com/forums/index.php?threads/send-email-from-details-page.28286/

When you place content plugin to display only in detail view:

{details:{fabrik view=form id=X mytable___element=[rowid]}}

You get closing Curly bracket '}' in the Form. This is not visible on detail view. It looks this curly bracket comes only when we use [rowid].

I do not know, this is specific to my server or bug. Someone please check.

 

[cheesegrits]

Yeah, it is a little bug. Not a trivial fix, as dealing with pattern matching of nested {} isn't easy. To give you an idea, the existing pattern, that attempts to remove the {details: ...} from the text when rendering a form view is ...

$text = preg_replace("/{details:\s*.*?}/is", '', $text);

... which does a "lazy" match on the closing }, so misses the second one in your text. But if I remove the "lazy" qualifier (the ?), it would then wouldn't work for anything with multiple sequential plugins like "{details: ...} blah blah {something else}" as it would remove everything up to that last }.

I played around with this ...

$text = preg_replace("/{details:({(?>[^{}]+|(?1))*})}/is", '', $text);

... which does a recursive sub-pattern match, so it finds the balanced {} and works for your example text, but then that doesn't work if there are no {} within the details text.

I'll carry on playing with that regex (regular expression) today, see if I can get it right.

-- hugh

 

[sunnyjey]

Oh, just wanted to bring you in the notice.

Thanks.

 

[cheesegrits]

It's kinda low down the priority list atm, I can't promise any kind of timeframe when I'll have time to look at it further.

-- hugh