List Pre-filters and F3.8

[stevelis]

Following an update visa GitHub on Wednesday 7th Feb, the following pre-filter has stopped working.
It displays all the information for the correct '{$my->id}' but now ignores the two date filters.
Any suggestions appreciated
Steve
Value = SELECT id FROM steward WHERE J_id ='{$my->id}'

 

[cheesegrits]

Which list? I'll log in to the site and check the debug output.

-- hugh

 

[stevelis]

Either of the following lists #49, #52, #54 have the similar pre-filters.
Thanks
Steve

 

[Sophist]

Have you used fabrikdebug=1 to check the SQL that is being produced? And in particular whether OR is taking precedence over AND?

i.e. I suspect that you want "start_date > 2018-01-01 AND end_date < 2018-03-31 AND (Chair = select OR steward = select OR steward = select)" but are actually getting "(start_date > 2018-01-01 AND end_date < 2018-03-31 AND Chair = select) OR steward = select OR steward = select"

If you re-sequence the filters to be "Chair = select OR steward = select OR steward = select AND start_date > 2018-01-01 AND end_date < 2018-03-31" you may get what you want.

As to why it has changed in the update from Github, that will need more research.

 

[troester]

There was a fix in GitHub which may address this issue
https://github.com/Fabrik/fabrik/commit/392b5a9c18f0db583933920ad281ab0e144c7826

 

[Sophist]

P.S. I was wondering what has changed in Pre-filters since your last update from Github - but not sure when that was. I was slightly worried that my PR#1914 was the cause - I can see has been included in your Github update because the Grouped buttons are now bootstrapped, but I have checked the code and don't think it could be the cause because it was essentially cosmetic to the Pre-filters tab.

I can't find anything obvious in the Fabrik commit log back to early last year.

 

[Sophist]

There was a fix in GitHub which may address this issue
https://github.com/Fabrik/fabrik/commit/392b5a9c18f0db583933920ad281ab0e144c7826

My search through the commit log was looking for anything with filter, so I didn't see this one. However, this fix was applied to the master branch in Nov 2017 and so will presumably already be included in @stevelis' update from Github.

 

[troester]

Yup.
So maybe it's really your PR.
There's a fairly "non-cosmetic" part...

 

[Sophist]

Well my code only touches the HTML definitions in the php, and the rest is in the JS file for the pre-filter tab on the back-end which handles adding new pre-filter rows, so should not have any impact on the front-end. But I am as good as, or even better than, most folks at including bugs in my code, so it is entirely possible that this is down to a bug in my PR.

 

[troester]

Tested:
it's coming from admin-filters(-min).js
before your PR list prefilter params are
...."filter-grouped":["0","1","0"],
directly after "Improve List Data Prefilter layout" commit it's
...."filter-grouped":{"1":"1","2":"0"},

with (screenshot after the PR)

and the rest is in the JS file for the pre-filter tab on the back-end which handles adding new pre-filter rows,

seems this is creating a different "filter-grouped" string in the list params

 

[Sophist]

Oops. I will take a look.

 

[troester]

Correction:
it's not "Improve List Data Prefilter layout" but the next one "Put group buttons inside a div."

 

[Sophist]

Ok - I found the issue (which was that a hidden input field for the first row was not being generated - which is why there was no "n/a" on that row.

Here are fixed files.

I will submit a PR for it in a sec.

@troester If you can verify it works ok, perhaps you can merge the PR.

 

[Sophist]

@stevelis You will need to download these two files to /administrator/components/com_fabrik/views/list/tmpl/ and remove the .txt from the end of the filename. Then clear browser-cache if you don't have fabrikdebug set to do JS busting.

And you will need to re-save the List as well I think.

 

[troester]

And you will need to re-save the List as well I think.

yes

 

[stevelis]

@Sophist,@troester
To you both, a big thanks
Have tested 2 of the 6 pre-filters which are now working just fine.
I will continue with the other but just wanted to let you both know it looks very good so far
Thanks for taking the time and doing the code - way above my league at the minute
I will leave the post open and close when all 6 are working.
Steve

 

[stevelis]

@Sophist,@troester
again, thanks to both of you as all the pre-filters are now working correctly.